[v0.4.6] s4: Fixes 374 #392
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Verify ExternalRules in RoleTemplates If the feature flag external-rules is enabled, the validation for RT follows this sequence: - 1) Reject if externalRules are provided and the user doesn’t have escalate permissions on RoleTemplates. - 2) Validate the policy rules defined in externalRules the same way as the already existing rules field. This validation leverages Kubernetes’ upstream validation. Webhook will validate this only if external is set to true. - 3) Use externalRules for resolving rules if provided. - 4) Use backing ClusterRole in the local cluster if externalRules are not provided. - 5) Reject if externalRules are not provided and there is no backing ClusterRole in the local cluster. For PRTB or CRTB: - 1) Use externalRules for resolving rules if provided. - 2) Use backing ClusterRole in the local cluster if externalRules are not provided. The previous verification process applies if the external-rules feature flag is disabled.
…#102) * Allow Restricted Admin to update external-rules feature flag * Check old value to see if feature is enabled * defaults to *,*,* for other different than enabling * only check for value changes * Add test * Move isUpdateAllowed to happen first * improve error message --------- Co-authored-by: Jonathan Crowther <[email protected]>
JonCrowther
approved these changes
Jun 11, 2024
raulcabello
approved these changes
Jun 11, 2024
pdellamore
approved these changes
Jun 11, 2024
raulcabello
added a commit
to raulcabello/webhook
that referenced
this pull request
Jun 18, 2024
* Update rancher/rancher/pkg/apis dependency * Verify ExternalRules in RoleTemplates If the feature flag external-rules is enabled, the validation for RT follows this sequence: - 1) Reject if externalRules are provided and the user doesn’t have escalate permissions on RoleTemplates. - 2) Validate the policy rules defined in externalRules the same way as the already existing rules field. This validation leverages Kubernetes’ upstream validation. Webhook will validate this only if external is set to true. - 3) Use externalRules for resolving rules if provided. - 4) Use backing ClusterRole in the local cluster if externalRules are not provided. - 5) Reject if externalRules are not provided and there is no backing ClusterRole in the local cluster. For PRTB or CRTB: - 1) Use externalRules for resolving rules if provided. - 2) Use backing ClusterRole in the local cluster if externalRules are not provided. The previous verification process applies if the external-rules feature flag is disabled. * Allow Restricted Admin to update external-rules feature flag (rancher#102) --------- Co-authored-by: Raul Cabello Martin <[email protected]> Co-authored-by: Jonathan Crowther <[email protected]>
Merged
raulcabello
added a commit
to raulcabello/webhook
that referenced
this pull request
Jun 18, 2024
* Update rancher/rancher/pkg/apis dependency * Verify ExternalRules in RoleTemplates If the feature flag external-rules is enabled, the validation for RT follows this sequence: - 1) Reject if externalRules are provided and the user doesn’t have escalate permissions on RoleTemplates. - 2) Validate the policy rules defined in externalRules the same way as the already existing rules field. This validation leverages Kubernetes’ upstream validation. Webhook will validate this only if external is set to true. - 3) Use externalRules for resolving rules if provided. - 4) Use backing ClusterRole in the local cluster if externalRules are not provided. - 5) Reject if externalRules are not provided and there is no backing ClusterRole in the local cluster. For PRTB or CRTB: - 1) Use externalRules for resolving rules if provided. - 2) Use backing ClusterRole in the local cluster if externalRules are not provided. The previous verification process applies if the external-rules feature flag is disabled. * Allow Restricted Admin to update external-rules feature flag (rancher#102) --------- Co-authored-by: Raul Cabello Martin <[email protected]> Co-authored-by: Jonathan Crowther <[email protected]>
Merged
raulcabello
added a commit
to raulcabello/webhook
that referenced
this pull request
Jun 18, 2024
* Update rancher/rancher/pkg/apis dependency * Verify ExternalRules in RoleTemplates If the feature flag external-rules is enabled, the validation for RT follows this sequence: - 1) Reject if externalRules are provided and the user doesn’t have escalate permissions on RoleTemplates. - 2) Validate the policy rules defined in externalRules the same way as the already existing rules field. This validation leverages Kubernetes’ upstream validation. Webhook will validate this only if external is set to true. - 3) Use externalRules for resolving rules if provided. - 4) Use backing ClusterRole in the local cluster if externalRules are not provided. - 5) Reject if externalRules are not provided and there is no backing ClusterRole in the local cluster. For PRTB or CRTB: - 1) Use externalRules for resolving rules if provided. - 2) Use backing ClusterRole in the local cluster if externalRules are not provided. The previous verification process applies if the external-rules feature flag is disabled. * Allow Restricted Admin to update external-rules feature flag (rancher#102) --------- Co-authored-by: Raul Cabello Martin <[email protected]> Co-authored-by: Jonathan Crowther <[email protected]>
raulcabello
added a commit
that referenced
this pull request
Jun 19, 2024
* [v0.4.6] s4: Fixes 374 (#392) * Update rancher/rancher/pkg/apis dependency * Verify ExternalRules in RoleTemplates If the feature flag external-rules is enabled, the validation for RT follows this sequence: - 1) Reject if externalRules are provided and the user doesn’t have escalate permissions on RoleTemplates. - 2) Validate the policy rules defined in externalRules the same way as the already existing rules field. This validation leverages Kubernetes’ upstream validation. Webhook will validate this only if external is set to true. - 3) Use externalRules for resolving rules if provided. - 4) Use backing ClusterRole in the local cluster if externalRules are not provided. - 5) Reject if externalRules are not provided and there is no backing ClusterRole in the local cluster. For PRTB or CRTB: - 1) Use externalRules for resolving rules if provided. - 2) Use backing ClusterRole in the local cluster if externalRules are not provided. The previous verification process applies if the external-rules feature flag is disabled. * Allow Restricted Admin to update external-rules feature flag (#102) --------- Co-authored-by: Raul Cabello Martin <[email protected]> Co-authored-by: Jonathan Crowther <[email protected]> * bump rancher to commit 2145c8e9d6034579caa6279856c59679f1102cf3 --------- Co-authored-by: Peter Matseykanets <[email protected]>
raulcabello
added a commit
to raulcabello/webhook
that referenced
this pull request
Jun 21, 2024
* Update rancher/rancher/pkg/apis dependency * Verify ExternalRules in RoleTemplates If the feature flag external-rules is enabled, the validation for RT follows this sequence: - 1) Reject if externalRules are provided and the user doesn’t have escalate permissions on RoleTemplates. - 2) Validate the policy rules defined in externalRules the same way as the already existing rules field. This validation leverages Kubernetes’ upstream validation. Webhook will validate this only if external is set to true. - 3) Use externalRules for resolving rules if provided. - 4) Use backing ClusterRole in the local cluster if externalRules are not provided. - 5) Reject if externalRules are not provided and there is no backing ClusterRole in the local cluster. For PRTB or CRTB: - 1) Use externalRules for resolving rules if provided. - 2) Use backing ClusterRole in the local cluster if externalRules are not provided. The previous verification process applies if the external-rules feature flag is disabled. * Allow Restricted Admin to update external-rules feature flag (rancher#102) --------- Co-authored-by: Raul Cabello Martin <[email protected]> Co-authored-by: Jonathan Crowther <[email protected]>
raulcabello
added a commit
to raulcabello/webhook
that referenced
this pull request
Jun 24, 2024
* Update rancher/rancher/pkg/apis dependency * Verify ExternalRules in RoleTemplates If the feature flag external-rules is enabled, the validation for RT follows this sequence: - 1) Reject if externalRules are provided and the user doesn’t have escalate permissions on RoleTemplates. - 2) Validate the policy rules defined in externalRules the same way as the already existing rules field. This validation leverages Kubernetes’ upstream validation. Webhook will validate this only if external is set to true. - 3) Use externalRules for resolving rules if provided. - 4) Use backing ClusterRole in the local cluster if externalRules are not provided. - 5) Reject if externalRules are not provided and there is no backing ClusterRole in the local cluster. For PRTB or CRTB: - 1) Use externalRules for resolving rules if provided. - 2) Use backing ClusterRole in the local cluster if externalRules are not provided. The previous verification process applies if the external-rules feature flag is disabled. * Allow Restricted Admin to update external-rules feature flag (rancher#102) --------- Co-authored-by: Raul Cabello Martin <[email protected]> Co-authored-by: Jonathan Crowther <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue:
Problem
Solution
CheckList